Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[S3 Data Lake] Rename every class to remove references to Iceberg v2 - Part 2 #51022

Merged
merged 9 commits into from
Jan 9, 2025
Merged

[S3 Data Lake] Rename every class to remove references to Iceberg v2 - Part 2 #51022

merged 9 commits into from
Jan 9, 2025

Conversation

frifriSF59
Copy link
Contributor

@frifriSF59 frifriSF59 commented Jan 9, 2025 •
edited
Loading

What

This time, we rename all the classes and the associated files to not have references to Iceberg V2

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:42pm

@frifriSF59 frifriSF59 changed the title Frifri/full rename iceberg [S3 Data Lake] Rename every class to remove references to Iceberg v2 - Part 2 Jan 9, 2025
@frifriSF59 frifriSF59 requested a review from edgao January 9, 2025 21:24
@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Jan 9, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (769a7b6)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 9, 2025
@frifriSF59 frifriSF59 force-pushed the frifri/full-rename-iceberg branch from 0fc880a to f920ff0 Compare January 9, 2025 21:29
@frifriSF59 frifriSF59 marked this pull request as ready for review January 9, 2025 21:30
@frifriSF59 frifriSF59 requested a review from a team as a code owner January 9, 2025 21:30
edgao
edgao approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't actually read most of the diff, seems generally reasonable

@frifriSF59 frifriSF59 merged commit c1f28cb into master Jan 9, 2025
31 checks passed
@frifriSF59 frifriSF59 deleted the frifri/full-rename-iceberg branch January 9, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3-data-lake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frifriSF59 @edgao @octavia-squidington-iii